AP_Bootloader: reserve board ids and range for Karshak Drones #28518
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyp1per
requested changes
Nov 4, 2024
|
@andyp1per - I changed the IDs from 188-211 to 4000-4040. Please check and let me know if you need me to make any other required changes. |
Rahul-Karshak
commented
Nov 5, 2024
peterbarker
requested changes
Nov 6, 2024
|
I've:
Marking as MergeOnCIPass now. Note that you might look at using "topic branches" for doing code changes on: https://ardupilot.org/dev/docs/git-branch.html . Using your master branch for creating PRs isn't a great workflow! |
Thank You, Mr. Peter Barker.
This is my first time creating a pull request to a public repository, thank you for pointing it out. I'm in the learning phase. I'll look into the hyperlink that you shared and learn. |
This commit is to reserve the available board ids within the given range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reserves the available board IDs within the given range of 189 to 211 for Karshak Drones. Changes are introduced after line 112 of the file board_types.txt, which is placed under Tools/AP_Bootloader/board_types.txt.